Added graceful shutdown for ctrl-C #123
Merged
+105
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error does not happen locally. Just on CI
webbnh
approved these changes
Nov 8, 2023
webbnh
approved these changes
Nov 8, 2023
webbnh
reviewed
Nov 8, 2023
mfleader
approved these changes
Nov 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes introduced with this PR
This adds a listener for ctrl-c.
The first time it gets it, it cancels the context which is supposed to gracefully end the workflow.
The second time it gets it, it warns the user of a forceful termination.
The last time, it exits the program.
Issues (if there are any) with the graceful exit deserve a separate PR. This just closes the context. If it doesn't close correctly, the problem is how it handles context close.
By contributing to this repository, I agree to the contribution guidelines.